Add unit test coverage for core modules#473
Open
TimElschner wants to merge 2 commits intoFinsys:mainfrom
Open
Conversation
Adds 110+ tests across 7 new test files covering utilities (version, diff, ip), encryption, git utils, notification utils, auth logic (rate limiting, password hashing), and authorization helpers. Exports maskSecrets and escapeTelegramMarkdown for direct testability.
TimElschner
force-pushed
the
tests/add-unit-test-coverage
branch
from
c6e15b9 to
4164a21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maskSecrets(git.ts) andescapeTelegramMarkdown(notifications.ts) for direct testabilityTest Files
tests/utils.test.tscompareVersions,shouldShowWhatsNew,computeAuditDiff,formatFieldName,ipToNumbertests/encryption.test.tsisEncrypted,generateKeytests/git-utils.test.tsmaskSecrets,parseEnvFileContenttests/notifications-utils.test.tsescapeTelegramMarkdowntests/auth.test.tshashPassword/verifyPasswordtests/authorize-helpers.test.tsunauthorized(),forbidden(),enterpriseRequired()tests/api-smoke.test.tsSource Changes (minimal)
src/lib/server/git.ts:function maskSecrets→export function maskSecretssrc/lib/server/notifications.ts:function escapeTelegramMarkdown→export function escapeTelegramMarkdownTest plan
bun test tests/utils.test.ts— 37 passbun test tests/encryption.test.ts— 24 passbun test tests/git-utils.test.ts— 23 passbun test tests/notifications-utils.test.ts— 9 passbun test tests/auth.test.ts— 13 passbun test tests/authorize-helpers.test.ts— 4 passbun test tests/api-smoke.test.ts— requires running Dockhand instance🤖 Generated with Claude Code